Global client_afrom_query (TALLOC_CTX *ctx, char const *identifier, char const *secret, char const *shortname, char const *type, char const *server, bool require_ma)

This function should die. SQL should use client_afrom_cs.

Global explode_xlat (char **out, size_t outlen, UNUSED void const *mod_inst, UNUSED void const *xlat_inst, REQUEST *request, char const *fmt)

should support multibyte delimiter for string types.

Global fr_canonicalize_error (TALLOC_CTX *ctx, char **sp, char **text, ssize_t slen, char const *msg)

merge with above function (radlog_request_marker)

Global fr_canonicalize_error (TALLOC_CTX *ctx, char **sp, char **text, ssize_t slen, char const *msg)

merge with above function (radlog_request_marker)

Global fr_cursor_remove (vp_cursor_t *cursor)

this is really inefficient and should be fixed...

Global fr_cursor_replace (vp_cursor_t *cursor, VALUE_PAIR *new)

this is really inefficient and should be fixed...

Global fr_dict_attr_add (fr_dict_t *dict, fr_dict_attr_t const *parent, char const *name, int attr, PW_TYPE type, fr_dict_attr_flags_t flags)

we need to check length of none vendor attributes.

Global fr_pair_delete_by_num (VALUE_PAIR **head, unsigned int vendor, unsigned int attr, int8_t tag)

should take DAs and do a point comparison.

Global fr_pair_find_by_num (VALUE_PAIR *head, unsigned int vendor, unsigned int attr, int8_t tag)

should take DAs and do a pointer comparison.

Global fr_pair_list_free (VALUE_PAIR **vps)

TLV: needs to free all dependents of each VP freed.

Global fr_pair_list_free (VALUE_PAIR **vps)

TLV: needs to free all dependents of each VP freed.

Global fr_pair_validate_debug (TALLOC_CTX *ctx, VALUE_PAIR const *failed[2])

add thread specific talloc contexts.

Global radius_find_compare (fr_dict_attr_t const *attribute)

this should probably take DA's.

Parameters

attribute to find comparison function for.

Returns

true if a comparison function was found
false.

Global request_will_proxy (REQUEST *request)

A lot of this logic is RADIUS specific, and should be moved out into a protocol specific function.

Global tmpl_expand (char const **out, char *buff, size_t bufflen, REQUEST *request, vp_tmpl_t const *vpt, xlat_escape_t escape, void *escape_ctx)

tmpl_expand should accept an enumv da from the lhs of the map.

Global tmpl_expand (char const **out, char *buff, size_t bufflen, REQUEST *request, vp_tmpl_t const *vpt, xlat_escape_t escape, void *escape_ctx)

tmpl_expand should accept an enumv da from the lhs of the map.